Tweak "From base R" vignette: #483
Conversation
- Define data in tribble and generate MD table from it. - The new table is ordered alphabetically by *stringr function name* for now, which I think is more accessible (base R API is just a mess whether we sort it alphabetically by name or not). But order can easily be changed later on if desired. - The new table has links to stringr's pkgdown reference when built by pkgdown. - Add missing `str_extract_all()` base R equivalent - Fix typo in fn name. - Use comment-style in-body YAML chunk opts - Cosmetic changes
vignettes/from-base.Rmd
Outdated
| "str_wrap(x)", "strwrap(x)" | ||
| ) | ||
|
|
||
| # since downlit seems to omit tables, we manually link to pkgdown reference for HTML output |
There was a problem hiding this comment.
I don't think this is the problem — I think the problem is that library(stringr) isn't shown in the output, so downlit can't see it. If you put library(stringr) in a separate chunk that's shown in the output, downlit should just work. This should substantially simplify the dependencies.
There was a problem hiding this comment.
I'm not familiar with how downlit works internally (it seems quite magic!). But the table cell content is still not autolinked even when there's a visible library(stringr) in the output:
I've tested a few combinations, none of them convinced downlit to autolink table cell contents. On the other hand, all code in text paragraphs is already properly linked without a visible library(stringr) chunk, so I think the issue lies elsewhere...
There was a problem hiding this comment.
Ok, in any case, I'd rather fix this upstream, rather than manually adding the links here.
There was a problem hiding this comment.
Would be great if this could be fixed in downlit. r-lib/downlit#67 is about a different issue though, right?
I've only added the links in the stringr column since I think they're more important when consulting this table. But I wouldn't mind if both columns were autolinked. 😄
Do you want me to remove the custom downlit-code?
There was a problem hiding this comment.
Yes, please file a downlit issue, and remove the custom downlit code.
There was a problem hiding this comment.
Removed the code. And filed r-lib/downlit#165.
and explicitly arrange table by stringr fn name
(This further reveals the mess in the base R API.)
|
Thanks! |
I think the new base R <-> stringr comparison table is incredibly useful! Just want to improve it in the following ways:
The new table has links to stringr's pkgdown reference when built by pkgdown thanks toRemoved as per @hadley's request.downlit::autolink_url().str_extract_all()base R equivalent