use_as_rownames function #8 #11

zhilongjia · 2015-12-18T11:09:01Z

use_as_rownames function returns data.frame, not tbl, with rownames. This is to solve issue #8.

Closes #8.

Closes #28.

krlmlr · 2015-12-18T11:12:30Z

R/dataframe.R

@@ -200,6 +200,34 @@ add_rownames <- function(df, var = "rowname") {
  as_data_frame(cbind(rn, df))
 }

+#' Convert a column of tbl into rownames of data.frame.


I'd prefer if the two functions were documented together (via @rdname).

codecov-io · 2015-12-18T11:12:37Z

Current coverage is `96.57%`

Merging #11 into master will increase coverage by +0.13% as of f2e0c32

@@            master     #11   diff @@
======================================
  Files           11      11       
  Stmts          422     438    +16
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            407     423    +16
  Partial          0       0       
  Missed          15      15

Review entire Coverage Diff as of f2e0c32

Powered by Codecov. Updated on successful CI builds.

krlmlr · 2015-12-18T11:14:24Z

R/dataframe.R

+    stop(paste("No", var, "column in the colnames.") )
+  }
+
+  df <- as.data.frame(df)


If this is intended behavior, it should be documented, but I wonder if it's necessary. (One can always write use_as_rownames() %>% as.data.frame or the other way round, if necessary.)

At least to me, use_as_rownames is to interact with the base::data.frame and tbl is trying to avoid rownames. So I convert it into data.frame directly. Comments?

Makes sense; still, needs to be documented.

I do not get meaning of to be documented. Return a data.frame is documented in details now. Correct?

Missed that, sorry.

…wnames.

zhilongjia · 2015-12-18T12:48:32Z

add_rownames keeps row names of data frame (Probably it affects a lots). And it will stop if there is a var column names in the input data frame.

More tests are added (I use test a few. Maybe need update).

use_as_rownames will update the row names using var whether it exists or not，then delete the var column. And it returns data.frame so far.

krlmlr · 2015-12-18T13:04:38Z

R/dataframe.R

-#' Convert row names to an explicit variable.
+#' Converting between rownames and a column
+#'
+#' add_rownames: Convert row names to an explicit variable.


This should go into the @details section

…re row names.

krlmlr · 2015-12-18T21:32:19Z

Thanks. This looks good, I'll merge it soon.

krlmlr · 2016-01-05T08:56:30Z

DESCRIPTION

@@ -25,4 +25,4 @@ Suggests:
    Lahman (>= 3.0.1)
 LazyData: yes
 License: MIT + file LICENSE
-RoxygenNote: 5.0.1.9000


This spurious change prevents me from merging into master.

…a.frame.

krlmlr · 2016-01-25T20:08:09Z

R/dataframe.R

 }

+#' @rdname rownames
+#' @export
+rownames_to_column <- add_rownames


The new function isn't supposed to convert to tbl_df. Let's remove add_rownames() altogether and keep it only in dplyr for compatibility.

rownames_to_column is a copy of add_rownames. So you mean keep the input of rownames_to_column as it is (I did not change that section)? For example, input data.frame output data.frame? I will remove add_rownames.

Yes, data.frame -> data.frame, tbl_df -> tbl_df. Thanks.

… data.

krlmlr · 2016-03-02T10:23:46Z

R/dataframe.R

 }

+#' \code{column_to_rownames} convert a column variable to row names. This is an
+#' inverted operation of rownames_to_column.


\code{rownames_to_column}

This description is for column_to_rownames. Why \code{rownames_to_column} ?

krlmlr · 2016-03-02T10:24:38Z

Thanks. Could you please merge/rebase?

@zhilongjia

- New `rownames_to_column()` and `column_to_rownames()` functions, replace `add_rownames()` (#11, @zhilongjia).

krlmlr · 2016-03-08T20:41:17Z

Thanks! I'll tweak documentation and tests myself.

@zhilongjia

- `frame_data()` now also creates a list column if one of the entries is a list (#32). - New `rownames_to_column()` and `column_to_rownames()` functions, replace `add_rownames()` (#11, @zhilongjia).

@r2evans

- Features - New `as_data_frame.table()` with argument `n` to control name of count column (#22, #23). - New function `repair_names()` fixes missing and duplicate names (#10, #15, @r2evans). - `frame_data()` now also creates a list column if one of the entries is a list (#32). - New `rownames_to_column()` and `column_to_rownames()` functions, replace `add_rownames()` (#11, @zhilongjia). - Use `tibble` prefix for options (#13, #36). - Documentation - Add pre-tibble NEWS (#39, #40). - Include vignette (#38). - Expand README. - Fix typos in documentation. - Remove use of `src()` from examples. - Prepare CRAN release - Use new-style `.travis.yml` - Use AppVeyor for testing. - Finer coverage analysis (#37). - Check with win-builder and valgrind. - Fix NOTE from `R CMD check`.

@jennybc

- Initial CRAN release - Extracted from `dplyr` 0.4.3 - Exported functions: - `tbl_df()` - `as_data_frame()` - `data_frame()`, `data_frame_()` - `frame_data()`, `tibble()` - `glimpse()` - `trunc_mat()`, `knit_print.trunc_mat()` - `type_sum()` - New `lst()` and `lst_()` create lists in the same way that `data_frame()` and `data_frame_()` create data frames (tidyverse/dplyr#1290). `lst(NULL)` doesn't raise an error (#17, @jennybc), but always uses deparsed expression as name (even for `NULL`). - New `add_row()` makes it easy to add a new row to data frame (tidyverse/dplyr#1021). - New `rownames_to_column()` and `column_to_rownames()` (#11, @zhilongjia). - New `has_rownames()` and `remove_rownames()` (#44). - New `repair_names()` fixes missing and duplicate names (#10, #15, @r2evans). - New `is_vector_s3()`. - Features - New `as_data_frame.table()` with argument `n` to control name of count column (#22, #23). - Use `tibble` prefix for options (#13, #36). - `glimpse()` now (invisibly) returns its argument (tidyverse/dplyr#1570). It is now a generic, the default method dispatches to `str()` (tidyverse/dplyr#1325). The default width is obtained from the `tibble.width` option (#35, #56). - `as_data_frame()` is now an S3 generic with methods for lists (the old `as_data_frame()`), data frames (trivial), matrices (with efficient C++ implementation) (tidyverse/dplyr#876), and `NULL` (returns a 0-row 0-column data frame) (#17, @jennybc). - Non-scalar input to `frame_data()` and `tibble()` (including lists) creates list-valued columns (#7). These functions return 0-row but n-col data frame if no data. - Bug fixes - `frame_data()` properly constructs rectangular tables (tidyverse/dplyr#1377, @kevinushey). - Minor modifications - Uses `setOldClass(c("tbl_df", "tbl", "data.frame"))` to help with S4 (tidyverse/dplyr#969). - `tbl_df()` automatically generates column names (tidyverse/dplyr#1606). - `tbl_df`s gain `$` and `[[` methods that are ~5x faster than the defaults, never do partial matching (tidyverse/dplyr#1504), and throw an error if the variable does not exist. `[[.tbl_df()` falls back to regular subsetting when used with anything other than a single string (#29). `base::getElement()` now works with tibbles (#9). - `all_equal()` allows to compare data frames ignoring row and column order, and optionally ignoring minor differences in type (e.g. int vs. double) (tidyverse/dplyr#821). Used by `all.equal()` for tibbles. (This package contains a pure R implementation of `all_equal()`, the `dplyr` code has identical behavior but is written in C++ and thus faster.) - The internals of `data_frame()` and `as_data_frame()` have been aligned, so `as_data_frame()` will now automatically recycle length-1 vectors. Both functions give more informative error messages if you are attempting to create an invalid data frame. You can no longer create a data frame with duplicated names (tidyverse/dplyr#820). Both functions now check that you don't have any `POSIXlt` columns, and tell you to use `POSIXct` if you do (tidyverse/dplyr#813). `data_frame(NULL)` raises error "must be a 1d atomic vector or list". - `trunc_mat()` and `print.tbl_df()` are considerably faster if you have very wide data frames. They will now also only list the first 100 additional variables not already on screen - control this with the new `n_extra` parameter to `print()` (tidyverse/dplyr#1161). The type of list columns is printed correctly (tidyverse/dplyr#1379). The `width` argument is used also for 0-row or 0-column data frames (#18). - When used in list-columns, S4 objects only print the class name rather than the full class hierarchy (#33). - Add test that `[.tbl_df()` does not change class (#41, @jennybc). Improve `[.tbl_df()` error message. - Documentation - Update README, with edits (#52, @bhive01) and enhancements (#54, @jennybc). - `vignette("tibble")` describes the difference between tbl_dfs and regular data frames (tidyverse/dplyr#1468). - Code quality - Test using new-style Travis-CI and AppVeyor. Full test coverage (#24, #53). Regression tests load known output from file (#49). - Renamed `obj_type()` to `obj_sum()`, improvements, better integration with `type_sum()`. - Internal cleanup.

zhilongjia added 2 commits December 17, 2015 18:08

add col2rowname

bf7b225

add use_as_rownames.

314eb7c

krlmlr reviewed Dec 18, 2015
View reviewed changes

add_rownames keeps row names of the input. add more test on use_as_ro…

8e7a8bb

…wnames.

krlmlr reviewed Dec 18, 2015
View reviewed changes

add_rownames return without row name. use_as_rownames stop if there a…

49da38e

…re row names.

krlmlr reviewed Jan 5, 2016
View reviewed changes

zhilongjia added 4 commits January 9, 2016 17:59

update use_as_rownames description.

221e2dc

debug test of use_as_rownames.

026b1a4

add rownames_to_column; column_to_rownames returns tbl instead of dat…

1eaaf5d

…a.frame.

add rownames_to_column test.

c710479

krlmlr reviewed Jan 25, 2016
View reviewed changes

krlmlr added the question label Jan 25, 2016

Delete add_rownames and rownames_to_column doesnot touch the class of…

9c17a0b

… data.

krlmlr removed the question label Mar 2, 2016

krlmlr reviewed Mar 2, 2016
View reviewed changes

krlmlr mentioned this pull request Mar 7, 2016

FR: Make a data frame from a (possibly named) vector or list #31

Closed

zhilongjia added 2 commits March 8, 2016 20:20

merge krlmlr's master.

591cd4d

merge conflict from krlmlr manually.

e35f2d1

krlmlr added a commit that referenced this pull request Mar 8, 2016

Merge pull request #11 from zhilongjia/master

f5012b7

- New `rownames_to_column()` and `column_to_rownames()` functions, replace `add_rownames()` (#11, @zhilongjia).

krlmlr merged commit f5012b7 into tidyverse:master Mar 8, 2016

github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use_as_rownames function #8 #11

use_as_rownames function #8 #11

zhilongjia commented Dec 18, 2015

krlmlr Dec 18, 2015

codecov-io commented Dec 18, 2015

krlmlr Dec 18, 2015

zhilongjia Dec 18, 2015

krlmlr Dec 18, 2015

zhilongjia Dec 18, 2015

krlmlr Dec 18, 2015

zhilongjia commented Dec 18, 2015

krlmlr Dec 18, 2015

krlmlr commented Dec 18, 2015

krlmlr Jan 5, 2016

krlmlr Jan 25, 2016

zhilongjia Jan 25, 2016

krlmlr Jan 25, 2016

krlmlr Mar 2, 2016

zhilongjia Mar 8, 2016

krlmlr commented Mar 2, 2016

krlmlr commented Mar 8, 2016

use_as_rownames function #8 #11

use_as_rownames function #8 #11

Conversation

zhilongjia commented Dec 18, 2015

Choose a reason for hiding this comment

codecov-io commented Dec 18, 2015

Current coverage is 96.57%

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhilongjia commented Dec 18, 2015

Choose a reason for hiding this comment

krlmlr commented Dec 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krlmlr commented Mar 2, 2016

krlmlr commented Mar 8, 2016

Current coverage is `96.57%`