Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_data_frame_matrix: "envir" argument in getS3method #202

Closed
itsdalmo opened this issue Jun 13, 2016 · 2 comments
Closed

as_data_frame_matrix: "envir" argument in getS3method #202

itsdalmo opened this issue Jun 13, 2016 · 2 comments

Comments

@itsdalmo
Copy link

It seems like envir is not a valid argument in utils::getS3method in R version 3.2.4. Couldn't find a specific mention of when this was added to R.utils, but unless there is something wrong with my R install I suppose this warrants a version bump for the R in DESCRIPTION.

getS3method is only used on one line however, so it might be a better idea to just add an if statement for older versions of R (where envir is not an argument) and something like this:

get("as_data_frame.matrix", envir = asNamespace("tibble"))

Could submit a PR if I have the right idea here (and figure out which version of R.utils added the argument).

-Kristian

@hadley
Copy link
Member

hadley commented Jun 13, 2016

Probably @krlmlr should at least take a look at this because he did the original PR.

I just submitted tidyr to CRAN so we'll probably need a fix soon.

@krlmlr
Copy link
Member

krlmlr commented Jun 13, 2016

It's been introduced in R 3.3.0 (wch/r-source@9d226b4940246d12#diff-a76a25f7e4bd0d72aded7945249a3a5aR255). I'll submit a compatibility fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants