This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
control: return pseudo phases if no schedule #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents lookupPhases from passing empty schedule IDs to Stripe, which causes an API error that bubbles up to Tier clients. The lookupPhases method will now return pseudo Phases in place of schedule phases if no schedule exists for a subscription at the time of calling. If a trialing, the first phase will be the trial phase. If a cancel is scheduled, a final "cancel" phase will be appended after the paid phase, if any. This allows callers to think in Phases/Schedules only and not worry about what a subscription is as well. Fixes #221
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents lookupPhases from passing empty schedule IDs to Stripe,
which causes an API error that bubbles up to Tier clients.
The lookupPhases method will now return pseudo Phases in place of
schedule phases if no schedule exists for a subscription at the time of
calling. If trialing, the first phase will be the trial phase. If a
cancel is scheduled, a final "cancel" phase will be appended after the
paid phase, if any.
This allows callers to think in Phases/Schedules only and not
worry about what a subscription is as well.
Fixes #221