Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for getting system information. #28

Merged
merged 2 commits into from
May 1, 2021
Merged

Conversation

reitermarkus
Copy link
Contributor

No description provided.

@ties
Copy link
Owner

ties commented Apr 29, 2021

I can't test it at the moment - but the code looks good. I would consider using a timedelta for the uptime. Let me know what you think about that.

@ties
Copy link
Owner

ties commented Apr 30, 2021

@reitermarkus let me know what you think about the usage of timedelta. If you don't think it is necessary or even inconvenient I'm ok with the current solution as well :)

@reitermarkus
Copy link
Contributor Author

Sounds good, updated to use timedelta.

@reitermarkus
Copy link
Contributor Author

Might also be good to create an enum for the network_access field, but I'm not sure which values are possible, or whether it's just a boolean.

@ties
Copy link
Owner

ties commented May 1, 2021

Might also be good to create an enum for the network_access field, but I'm not sure which values are possible, or whether it's just a boolean.

Let's go with the current implementation. We can always revise it later!

@ties ties merged commit 472f4fa into ties:master May 1, 2021
@ties
Copy link
Owner

ties commented May 1, 2021

Merged! And I released 0.3.2 which includes this.

@reitermarkus reitermarkus deleted the patch-1 branch May 1, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants