-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP pool controller for more powerful IP pool UX #2658
Merged
caseydavenport
merged 36 commits into
tigera:master
from
caseydavenport:casey-pool-controller
Mar 20, 2024
Merged
IP pool controller for more powerful IP pool UX #2658
caseydavenport
merged 36 commits into
tigera:master
from
caseydavenport:casey-pool-controller
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
commented
May 22, 2023
Brian-McM
reviewed
Jun 2, 2023
caseydavenport
force-pushed
the
casey-pool-controller
branch
from
November 13, 2023 21:45
cf93c65
to
a1c579e
Compare
caseydavenport
commented
Dec 6, 2023
caseydavenport
commented
Dec 6, 2023
tmjd
reviewed
Dec 6, 2023
caseydavenport
force-pushed
the
casey-pool-controller
branch
3 times, most recently
from
December 18, 2023 23:11
05a3329
to
1ccfdba
Compare
caseydavenport
force-pushed
the
casey-pool-controller
branch
from
January 3, 2024 23:59
1ccfdba
to
9bb9bf2
Compare
caseydavenport
changed the title
Prototype: IP pool controller
IP pool controller for more powerful IP pool UX
Jan 3, 2024
caseydavenport
force-pushed
the
casey-pool-controller
branch
from
January 4, 2024 17:18
d0da20e
to
116f494
Compare
caseydavenport
force-pushed
the
casey-pool-controller
branch
2 times, most recently
from
January 31, 2024 22:22
31f1908
to
b7347ce
Compare
caseydavenport
force-pushed
the
casey-pool-controller
branch
3 times, most recently
from
March 1, 2024 22:55
eeade52
to
85b2b81
Compare
caseydavenport
force-pushed
the
casey-pool-controller
branch
from
March 18, 2024 17:57
212a0bc
to
c8300af
Compare
Brian-McM
approved these changes
Mar 18, 2024
This was referenced Mar 20, 2024
caseydavenport
added a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More capable IP pool management controller in the operator.
It is meant to enable a few key use-cases:
The standard install-time flow is this:
The IP pool controller will refuse to update existing IP pools, or delete IP pools, if the Calico API server is not running. This ensures we have proper validation and defaulting enforced, while allowing a small window using the crd.projectcalico.org API to bootstrap the cluster.
On upgrade, the IP pool controller will attempt to take over control of any IP pools in the cluster that match those in the Installation resource. This allows the operator to assume control of IP pools it previously had created. If there are IP pools present that are NOT in the Installation (and not owned by the controller), they will be ignored by the controller.
Other changes in this PR:
For PR author
make gen-files
make gen-versions
This PR includes a handful of termination / uninstall changes that are made necessary by the new FV tests added for the IP pool controller exposing an existing bug that is fixed by:
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.