Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #2687 Openshift namespace label #2689

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Cherry-pick #2687 Openshift namespace label #2689

merged 1 commit into from
Jun 12, 2023

Conversation

MichalFupso
Copy link
Contributor

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@MichalFupso MichalFupso requested a review from a team as a code owner June 8, 2023 19:57
@marvin-tigera marvin-tigera added this to the v1.30.2 milestone Jun 8, 2023
@tmjd tmjd modified the milestones: v1.30.2, v1.30.3 Jun 8, 2023
@rene-dekker rene-dekker added the hold merge Do not merge label Jun 8, 2023
tmjd
tmjd approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it has the hold merge label.

@rene-dekker rene-dekker merged commit 57ebe7f into tigera:release-v1.30 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-pr-required hold merge Do not merge release-note-required
Projects
None yet
Milestone
v1.30.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalFupso @tmjd @rene-dekker @marvin-tigera