Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSPs for dex and policy recommendation #2757

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

hjiawei
Copy link
Contributor

@hjiawei hjiawei commented Jul 21, 2023

Description

PSPs are needed in a k8s <= v1.24 cluster when pod admission controller is enabled. This change adds PSPs for Tigera dex and policy recommendation components.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@hjiawei
Copy link
Contributor Author

hjiawei commented Jul 21, 2023

cc @rene-dekker and @dimitri-nicolo.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PSPs are needed in a k8s <= v1.24 cluster when pod admission controller is
enabled. This change adds PSPs for Tigera dex and policy recommendation
components.
@rene-dekker
Copy link
Member

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit ac4a9de into tigera:master Jul 24, 2023
3 checks passed
@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

@hjiawei hjiawei deleted the psp-dex-polrec branch July 24, 2023 20:52
@hjiawei hjiawei mentioned this pull request Jul 25, 2023
5 tasks
@danudey danudey modified the milestones: v1.31.0, v1.32.0 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants