Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add egressgatewaypolicies to node RBAC #2893

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add egressgatewaypolicies to node RBAC #2893

merged 2 commits into from
Sep 28, 2023

Conversation

mazdakn
Copy link
Member

@mazdakn mazdakn commented Sep 22, 2023

Description

Allow node to list egressgatewaypolicies.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@mazdakn mazdakn requested a review from a team as a code owner September 22, 2023 21:20
@marvin-tigera marvin-tigera added this to the v1.32.0 milestone Sep 22, 2023
coutinhop
coutinhop approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@coutinhop coutinhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tmjd
tmjd approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit 47ae08d into tigera:master Sep 28, 2023
5 checks passed
This was referenced Sep 29, 2023
Merged
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutinhop coutinhop coutinhop approved these changes

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mazdakn @coutinhop @tmjd @marvin-tigera