Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support ebpf and ipv6 #2945

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

sridhartigera
Copy link
Contributor

@sridhartigera sridhartigera commented Oct 24, 2023

Description

Remove the check to disallow eBPF and IPv6.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

if bpfDataplane && instance.Spec.CalicoNetwork.NodeAddressAutodetectionV4 == nil {
return fmt.Errorf("spec.calicoNetwork.nodeAddressAutodetectionV4 is required for the BPF dataplane")
if bpfDataplane {
if bpfIPv6Enabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some indent issue?

Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I will let operator-maintainers to approve :)

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sridhartigera sridhartigera merged commit 13aeae4 into tigera:master Oct 26, 2023
5 checks passed
@sridhartigera sridhartigera deleted the bpf-ipv6 branch October 26, 2023 13:56
sridhartigera added a commit to sridhartigera/operator that referenced this pull request Nov 20, 2023
* Changes to support ebpf and ipv6
@sridhartigera sridhartigera mentioned this pull request Nov 20, 2023
5 tasks
rene-dekker pushed a commit that referenced this pull request Nov 20, 2023
* Changes to support ebpf and ipv6 (#2945)

* Changes to support ebpf and ipv6
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants