Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 1.29] update x/net #2974

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Behnam-Shobiri
Copy link
Contributor

Description

update x/net
#2970

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@Behnam-Shobiri Behnam-Shobiri requested a review from a team as a code owner November 2, 2023 16:32
@marvin-tigera marvin-tigera added this to the v1.29.8 milestone Nov 2, 2023
@Behnam-Shobiri Behnam-Shobiri changed the title update x/net [release 1.29] update x/net Nov 2, 2023
@rene-dekker
Copy link
Member

/merge-when-ready delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmjd
Copy link
Member

tmjd commented Nov 3, 2023

CI looked like it timed out, I kicked it to run again. We'll see if it was a flake.

@marvin-tigera marvin-tigera merged commit cf1ca87 into tigera:release-v1.29 Nov 3, 2023
2 checks passed
@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

@Behnam-Shobiri Behnam-Shobiri deleted the update-net-29 branch November 3, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants