Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-tenant elasticsearch configuration #2981

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Per-tenant elasticsearch configuration #2981

merged 2 commits into from
Nov 17, 2023

Conversation

caseydavenport
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@caseydavenport caseydavenport requested a review from a team as a code owner November 3, 2023 18:18
@marvin-tigera marvin-tigera added this to the v1.32.0 milestone Nov 3, 2023
@caseydavenport caseydavenport force-pushed the casey-elastic-external branch 2 times, most recently from 21135f7 to 5db0e2f Compare November 3, 2023 18:22
@caseydavenport caseydavenport force-pushed the casey-elastic-external branch 2 times, most recently from 7af4415 to 6e29916 Compare November 6, 2023 23:21
tmjd
tmjd reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the plan/expectation for the kube-controllers image used with external ES being a different build?

main.go Show resolved Hide resolved
pkg/controller/logstorage/elastic/external_elastic_controller.go Show resolved Hide resolved
pkg/controller/logstorage/elastic/external_elastic_controller.go Show resolved Hide resolved
pkg/controller/logstorage/elastic/external_elastic_controller.go Show resolved Hide resolved
@caseydavenport
Copy link
Member Author

@tmjd fixed!

tmjd
tmjd reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving for @asincu 's approval too. (I might have to come back and give a final approval since I don't know if you have enough permissions to meet the PR requirements.)

asincu
asincu reviewed Nov 16, 2023
View reviewed changes
pkg/controller/logstorage/linseed/linseed_controller.go Show resolved Hide resolved
pkg/render/logstorage/linseed/linseed.go Show resolved Hide resolved
pkg/render/logstorage/linseed/linseed_test.go Show resolved Hide resolved
api/v1/tenant_types.go Show resolved Hide resolved
main.go Show resolved Hide resolved
pkg/controller/utils/utils.go Show resolved Hide resolved
pkg/render/common/elasticsearch/service.go Outdated Show resolved Hide resolved
pkg/render/logstorage/external.go Outdated Show resolved Hide resolved
pkg/render/logstorage/external.go Show resolved Hide resolved
pkg/controller/manager/manager_controller.go Show resolved Hide resolved
@caseydavenport caseydavenport force-pushed the casey-elastic-external branch 2 times, most recently from cccd170 to 7596ff0 Compare November 17, 2023 00:15
asincu
asincu approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@asincu asincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a small comment

pkg/render/logstorage/linseed/linseed_test.go Show resolved Hide resolved
@caseydavenport caseydavenport merged commit 46ad688 into tigera:master Nov 17, 2023
5 checks passed
@caseydavenport caseydavenport deleted the casey-elastic-external branch November 17, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd left review comments

@asincu asincu asincu approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@caseydavenport @tmjd @asincu @marvin-tigera