Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail on not found for RequiresTigeraSecure as that just indicat… #3105

Closed
wants to merge 1 commit into from

Conversation

paulgmiller
Copy link
Contributor

@paulgmiller paulgmiller commented Jan 10, 2024

…es crds have not been applied

Description

Was trying to apply tigera-operator without any CRDS (but with the arg --manage-crds) and failed in RequiresTigeraSecure.

Seems like not found should be treated differently than other errors here.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.33.0 milestone Jan 10, 2024
@danudey danudey modified the milestones: v1.33.0, v1.33.1, v1.34.0 Jan 31, 2024
@radTuti radTuti modified the milestones: v1.34.0, v1.34.1 May 11, 2024
@danudey danudey modified the milestones: v1.34.1, v1.34.2 Jun 21, 2024
@danudey danudey modified the milestones: v1.34.2, v1.34.3 Jul 24, 2024
@danudey danudey modified the milestones: v1.34.3, v1.34.4 Jul 31, 2024
@danudey danudey modified the milestones: v1.34.4, v1.34.5 Sep 19, 2024
@danudey danudey modified the milestones: v1.34.5, v1.34.6, v1.34.7 Oct 22, 2024
@caseydavenport caseydavenport removed this from the v1.34.7 milestone Oct 28, 2024
@marvin-tigera marvin-tigera added this to the v1.37.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants