Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zeroed kube-controllers metric port #3120

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

pasanw
Copy link
Contributor

@pasanw pasanw commented Jan 12, 2024

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pasanw pasanw force-pushed the support-zeroed-kc-metrics-port branch from 8609105 to 6fb77cb Compare January 12, 2024 23:41
@pasanw pasanw merged commit 9e93966 into tigera:master Jan 16, 2024
5 checks passed
@pasanw pasanw deleted the support-zeroed-kc-metrics-port branch January 16, 2024 00:34
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants