Report TigeraStatus for tiers #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasanw
force-pushed
the
tiers-reporting
branch
2 times, most recently
from
fe22139
to
d49ca9e
Compare
pasanw
force-pushed
the
tiers-reporting
branch
from
d49ca9e
to
4796bac
Compare
Brian-McM
reviewed
Jan 18, 2024
| @@ -133,6 +133,9 @@ func (r *ReconcileTiers) Reconcile(ctx context.Context, request reconcile.Reques | |||
| reqLogger := log.WithValues("Request.Namespace", request.Namespace, "Request.Name", request.Name) | |||
| reqLogger.Info("Reconciling Tiers") | |||
|
|
|||
| // Mark CR as found even though this controller is not associated with a CR, as OnCRFound() enables TigeraStatus reporting. | |||
| r.status.OnCRFound() | |||
There was a problem hiding this comment.
So we were already attempting to report a tier status, this was all that prevented it from actually being reported?
There was a problem hiding this comment.
Yeah, the controller was already following the pattern of reporting a degraded status before failing the reconcile, perhaps from copy-paste. It was intentional for the controller to not report to TigeraStatus though
caseydavenport
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a UT flake.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.