Migrate job installer to run inside elasticsearch namespace #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asincu
force-pushed
the
migrate_job_installer
branch
from
b29caa1
to
63b1a66
Compare
caseydavenport
requested changes
Jan 22, 2024
pkg/controller/logstorage/dashboards/dashboards_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/logstorage/dashboards/dashboards_controller_test.go
Outdated
Show resolved
Hide resolved
caseydavenport
approved these changes
Jan 25, 2024
asincu
force-pushed
the
migrate_job_installer
branch
from
bd437f9
to
e7eff2f
Compare
Code review! Fix credentials and add resources per tenant Code reviews and test fixes [CODE REVIEW] Use ReplicatedPodOverrides Fix! GetDeployment strategy cannot panic [CODE REVIEW] Remove egress rule Remove multi-tenant tests [Code review] Add tigera-status
asincu
force-pushed
the
migrate_job_installer
branch
from
e7eff2f
to
5ac0d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate intrusion detection installer to a job inside elasticsearch namespace that access Kibana directly.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.