Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make gen-files #3163

Merged
merged 1 commit into from
Feb 12, 2024
Merged

make gen-files #3163

merged 1 commit into from
Feb 12, 2024

Conversation

electricjesus
Copy link
Member

Description

Fix static files check failure

  • update felixconfiguration crd

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@electricjesus electricjesus requested a review from a team as a code owner February 12, 2024 16:16
@marvin-tigera marvin-tigera added this to the v1.34.0 milestone Feb 12, 2024
tmjd
tmjd approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electricjesus
Copy link
Member Author

/merge-when-ready squash-commits delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit 0b674df into tigera:master Feb 12, 2024
5 checks passed
@electricjesus electricjesus deleted the fix-felixconfig-make-genfiles branch February 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd approved these changes

Assignees
No one assigned
Labels
docs-pr-required merge-when-ready release-note-required squash-commits
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@electricjesus @marvin-tigera @tmjd