refactor: set kube network based on cni type instead of provider

[davidgiga1993]

Description

Changes the behavior how the kubeNetwork environment variable is defined by looking at the actual used CNI type instead of the k8s platform.

Fixes #3165

For PR author

• Tests for change.
• If changing pkg/apis/, run make gen-files
• If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

• Milestone set according to targeted release.
• Appropriate labels:
  • kind/bug if this is a bugfix.
  • kind/enhancement if this is a a new feature.
  • enterprise if this PR applies to Calico Enterprise only.

[CLAassistant]

All committers have signed the CLA.

[coutinhop]

/sem-approve

[davidgiga1993]

Anything I should be doing? I can't see the CI logs in case it was caused by this mr

[caseydavenport]

diff -u pkg/render/windows.go.orig pkg/render/windows.go00:31
--- pkg/render/windows.go.orig	2024-02-21 18:43:44.264553431 +000000:31
+++ pkg/render/windows.go	2024-02-21 18:43:44.264553431 +000000:31
@@ -591,7 +591,7 @@00:31
 	if c.cfg.Installation.CNI != nil && c.cfg.Installation.CNI.Type == operatorv1.PluginAzureVNET {00:31
 		kubeNetwork = "azure.*"00:31
 	}00:31
-	00:31
+00:31
 	windowsEnv = append(windowsEnv, corev1.EnvVar{Name: "KUBE_NETWORK", Value: kubeNetwork})00:31
 00:31
 	// Determine MTU to use. If specified explicitly, use that. Otherwise, set defaults based on an overall00:31
  goimports would make changes to file: pkg/render/windows.go00:31
Some files failed gofmt check.  Run 00:31
  make fix

It's failing the static checks (which can be run locally with make static-checks).

[coutinhop]

/sem-approve

[caseydavenport]

Looks like an actual test failure now:

Class name
pkg/render Suite
Failure
/go/src/github.com/tigera/operator/pkg/render/windows_test.go:1041
Expected
    <int>: 1
to equal
    <int>: 2
/go/src/github.com/tigera/operator/pkg/render/windows_test.go:1061

[davidgiga1993]

I did some adjustments to the test as it seems like it wasn't checking the correct case according to the description. Let me know if that is the expected behavior now

[song-jiang]

@davidgiga1993 I can see the code changes you are making for the test is correct. Restarted CI run to see if it'll pass.

[song-jiang]

/sem-approve

[song-jiang]

LGTM

[song-jiang]

@coutinhop @caseydavenport Could you take a look and if everything's ok please help to approve&merge. Thanks.