-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: set kube network based on cni type instead of provider #3166
Conversation
d04516e
to
8a47291
Compare
/sem-approve |
Anything I should be doing? I can't see the CI logs in case it was caused by this mr |
It's failing the static checks (which can be run locally with |
/sem-approve |
Looks like an actual test failure now:
|
I did some adjustments to the test as it seems like it wasn't checking the correct case according to the description. Let me know if that is the expected behavior now |
@davidgiga1993 I can see the code changes you are making for the test is correct. Restarted CI run to see if it'll pass. |
/sem-approve |
LGTM |
@coutinhop @caseydavenport Could you take a look and if everything's ok please help to approve&merge. Thanks. |
Description
Changes the behavior how the kubeNetwork environment variable is defined by looking at the actual used CNI type instead of the k8s platform.
Fixes #3165
For PR author
make gen-files
make gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.