Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logcollector - Make resource requests/limits configurable #3206

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

vara2504
Copy link
Contributor

@vara2504 vara2504 commented Feb 27, 2024

Fluentd DS:

vara@vara:~/bzprofiles/Clusters/tc_config$ kubectl patch logcollector tigera-secure  --type=merge --patch='{"spec": {"fluentdDaemonSet":{"spec": {"template": {"spec": {"containers":[{"name":"fluentd","resources":{"limits":{"cpu":"150m", "memory":"500Mi"},"requests":{"cpu":"20m", "memory":"50Mi"}}}]}}}}}}'
logcollector.operator.tigera.io/tigera-secure patched

vara@vara:~/bzprofiles/Clusters/tc_config$ k get daemonset.apps/fluentd-node -n tigera-fluentd -o yaml|grep -A 6 -B 1 resources
          timeoutSeconds: 10
        resources:
          limits:
            cpu: 150m
            memory: 500Mi
          requests:
            cpu: 20m
            memory: 50Mi

EKS:

vara@vara:~/bzprofiles/Clusters/tc_eks$ kubectl patch logcollector tigera-secure  --type=merge --patch='{"spec": {"eksLogForwarderDeployment": {"spec": {"template": {"spec": {"containers":[{"name":"eks-log-forwarder","resources":{"limits":{"cpu":"150m", "memory":"500Mi"},"requests":{"cpu":"20m", "memory":"50Mi"}}}]}}}}}}'
logcollector.operator.tigera.io/tigera-secure patched
vara@vara:~/bzprofiles/Clusters/tc_eks$ k get deployment.apps/eks-log-forwarder -n tigera-fluentd -o yaml|grep -A 7 -B 1 resources
        name: eks-log-forwarder
        resources:
          limits:
            cpu: 150m
            memory: 500Mi
          requests:
            cpu: 20m
            memory: 50Mi
        securityContext:
--
        name: eks-log-forwarder-startup
        resources: {}
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL
          privileged: false
          runAsGroup: 0

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

UT Logcollector - Make resource requests/limits configurable
@vara2504 vara2504 marked this pull request as ready for review February 29, 2024 16:13
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker rene-dekker merged commit df999a4 into tigera:master Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants