Move test utilities to test package fromt utils folder to move ginkgo v1 import #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian-McM
force-pushed
the
bm-update-test-package-names
branch
2 times, most recently
from
5fb4f1a
to
672dee0
Compare
Brian-McM
changed the title
Brian-McM
force-pushed
the
bm-update-test-package-names
branch
from
672dee0
to
32198df
Compare
Brian-McM
changed the title
… v1 import Currently we import ginkgo v1 in the utils.go folder for test utilities. This means that anything importing the controllers package also imports ginkgo v1, and if that importer also imports ginkgo v2 then a panic will occur. Moving the test utilities to the test folder ensures we don't import ginkgo v1 when we're using the controller libraries.
Brian-McM
force-pushed
the
bm-update-test-package-names
branch
from
32198df
to
d522394
Compare
Brian-McM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we import ginkgo v1 in the utils.go folder for test utilities.
This means that anything importing the controllers package also
imports ginkgo v1, and if that importer also imports ginkgo v2 then a
panic will occur.
Moving the test utilities to the test folder ensures we don't import
ginkgo v1 when we're using the controller libraries.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.