Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Layer - Make resources configurable for requests/limits #3216

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

vara2504
Copy link
Contributor

@vara2504 vara2504 commented Mar 1, 2024

 vara@vara:~/bzprofiles/Clusters/tc_config$ kubectl patch applicationlayer tigera-secure  --type=merge --patch='{"spec": {"l7LogCollectorDaemonSet":{"spec": {"template": {"spec": {"containers":[{"name":"envoy-proxy","resources":{"limits":{"cpu":"151m", "memory":"501Mi"},"requests":{"cpu":"21m", "memory":"51Mi"}}},{"name":"l7-collector","resources":{"limits":{"cpu":"152m", "memory":"502Mi"},"requests":{"cpu":"22m", "memory":"52Mi"}}},{"name":"dikastes","resources":{"limits":{"cpu":"153m", "memory":"503Mi"},"requests":{"cpu":"23m", "memory":"53Mi"}}}]}}}}}}'
applicationlayer.operator.tigera.io/tigera-secure patched
vara@vara:~/bzprofiles/Clusters/tc_config$ k get daemonset.apps/l7-log-collector -n calico-system -o yaml|grep -A 7 -B 1 resources
        name: envoy-proxy
        resources:
          limits:
            cpu: 151m
            memory: 501Mi
          requests:
            cpu: 21m
            memory: 51Mi
        securityContext:
--
        name: l7-collector
        resources:
          limits:
            cpu: 152m
            memory: 502Mi
          requests:
            cpu: 22m
            memory: 52Mi
        securityContext:
--
        name: dikastes
        resources:
          limits:
            cpu: 153m
            memory: 503Mi
          requests:
            cpu: 23m
            memory: 53Mi
        securityContext:

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.34.0 milestone Mar 1, 2024
@vara2504 vara2504 marked this pull request as ready for review March 5, 2024 17:09
@vara2504 vara2504 requested a review from a team as a code owner March 5, 2024 17:09
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker rene-dekker merged commit 6913ddf into tigera:master Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants