Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix features annotations #3222

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

lwr20
Copy link
Member

@lwr20 lwr20 commented Mar 4, 2024

Description

Openshift need feature annotations to look like this:

metadata:
  annotations:
    features.operators.openshift.io/disconnected: "false"
    features.operators.openshift.io/fips-compliant: "false"
    features.operators.openshift.io/proxy-aware: "false"

Example of bundle generated with this code has been merged by Openshift:
https://github.com/redhat-openshift-ecosystem/certified-operators/blob/main/operators/tigera-operator/1.32.3/manifests/tigera-operator.clusterserviceversion.yaml#L31-L40

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera merged commit 3287f59 into tigera:master Mar 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants