Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.34] Auto pick #3254: Fix setting of resources for the CSI node driver #3255

Conversation

caseydavenport
Copy link
Member

Cherry pick of #3254 on release-v1.34.

#3254: Fix setting of resources for the CSI node driver

Original PR Body below

Description

Finishes off this abandoned PR: #2768

Fixes projectcalico/calico#8400

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

botchk and others added 3 commits March 20, 2024 14:31
* Change installation CRD to allow the CSI node driver container names
* Change validation logic for the CSI node driver to allow resources
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caseydavenport caseydavenport merged commit eba91a1 into tigera:release-v1.34 Mar 21, 2024
2 checks passed
@caseydavenport caseydavenport deleted the auto-pick-of-#3254-origin-release-v1.34 branch March 21, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants