Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add egress rule to allow dashboards to connect to external Kibana #3294

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

asincu
Copy link
Contributor

@asincu asincu commented Apr 3, 2024

Description

Single tenant with external Kibana need to access the external Kibana URL to setup up the dashboards in the tenant namespace. We need to create an egress rule to match that.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but I don't need to review again after

@asincu asincu merged commit 337e604 into tigera:master Apr 4, 2024
5 checks passed
@asincu asincu deleted the dashboards_access branch April 4, 2024 15:27
asincu added a commit to asincu/operator that referenced this pull request Apr 4, 2024
…gera#3294)

* Add egress rule to allow dashboards to connect to external Kibana

* [CODE REVIEW] Update variable parsing and name

* [CODE REVIEW] Move logic in controller

* [CODE REVIEW] Consolidate variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants