[release-v1.33][cherry-pick] Fix CNI plugin configuration issue

[Tamas-Biro1]

Description

• this PR cherry-picks fix CNI plugin configuration issue #3087 which was a bugfix for CNI plugin configuration
• without this, the original feature CNI tuning plugin configuration added to Installation CRD #2708 could not work in some cases
• for testing, see the PR 3087

For PR author

• Tests for change.
• If changing pkg/apis/, run make gen-files
• If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

• Milestone set according to targeted release.
• Appropriate labels:
  • kind/bug if this is a bugfix.
  • kind/enhancement if this is a a new feature.
  • enterprise if this PR applies to Calico Enterprise only.

[tmjd]

/sem-approve

[Tamas-Biro1]

@tmjd can you paste the actual error from semaphore CI, that i can take a look at? thanks!

[tmjd]

Sorry it took me so long to get back here

Convert network tests handle Calico CNI migration Calico CNI config flags migrate tuning setting 10:08
  sysctl tuning in config10:08
  /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:75910:08
2024-04-12T12:57:01Z	INFO	migration_convert	did not detect typha10:08
• Failure [0.001 seconds]10:08
Convert network tests10:08
/go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:4310:08
  handle Calico CNI migration10:08
  /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:10510:08
    Calico CNI config flags10:08
    /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:75710:08
      migrate tuning setting10:08
      /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:75810:08
        sysctl tuning in config [It]10:08
        /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:75910:08
        Expected10:08
            <[]v1.Sysctl | len:3, cap:4>: [10:08
                {10:08
                    Key: "net.ipv4.tcp_keepalive_time",10:08
                    Value: "40",10:08
                },10:08
                {10:08
                    Key: "net.ipv4.tcp_keepalive_intvl",10:08
                    Value: "15",10:08
                },10:08
                {10:08
                    Key: "net.ipv4.tcp_keepalive_probes",10:08
                    Value: "6",10:08
                },10:08
            ]10:08
        to equal10:08
            <[]v1.Sysctl | len:3, cap:3>: [10:08
                {10:08
                    Key: "net.ipv4.tcp_keepalive_intvl",10:08
                    Value: "15",10:08
                },10:08
                {10:08
 10:08
                    Value: "6",10:08
                },10:08
                {10:08
                    Key: "net.ipv4.tcp_keepalive_time",10:08
                    Value: "40",10:08
                },10:08
            ]10:08
        /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:79910:08
        Full Stack Trace10:08
        github.com/tigera/operator/pkg/controller/migration/convert.glob..func8.3.19.1.1()10:08
        	/go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:799 +0x61510:08
        github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc000337520?)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/leafnodes/runner.go:113 +0x9d10:08
        github.com/onsi/ginkgo/internal/leafnodes.(*runner).run(0x14b3982?)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/leafnodes/runner.go:64 +0xd810:08
        github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run(0xc00009c820?)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/leafnodes/it_node.go:26 +0x5b10:08
        github.com/onsi/ginkgo/internal/spec.(*Spec).runSample(0xc00067ce10, 0xc000767990?, {0x1beaf00?, 0xc00031d1c0})10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/spec/spec.go:215 +0x2a910:08
        github.com/onsi/ginkgo/internal/spec.(*Spec).Run(0xc00067ce10, {0x1beaf00, 0xc00031d1c0})10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/spec/spec.go:138 +0xe510:08
        github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec(0xc000189b80, 0xc00067ce10)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/specrunner/spec_runner.go:200 +0xe710:08
        github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs(0xc000189b80)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/specrunner/spec_runner.go:170 +0x1a510:08
        github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run(0xc000189b80)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/specrunner/spec_runner.go:66 +0xb710:08
        github.com/onsi/ginkgo/internal/suite.(*Suite).Run(0xc0003438f0, {0x7fb801349f00, 0xc000107860}, {0x19a7f6c, 0x2e}, {0xc0004c0d60, 0x2, 0x2}, {0x1c055e0, 0xc00031d1c0}, ...)10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/internal/suite/suite.go:79 +0x5ca10:08
        github.com/onsi/ginkgo.runSpecsWithCustomReporters({0x1bea840?, 0xc000107860}, {0x19a7f6c, 0x2e}, {0xc0004c0d40, 0x2, 0x1982dc9?})10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:245 +0x20c10:08
        github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters({0x1bea840, 0xc000107860}, {0x19a7f6c, 0x2e}, {0xc000072f08, 0x1c6c775?, 0x1})10:08
        	/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:228 +0x19b10:08
        github.com/tigera/operator/pkg/controller/migration/convert_test.TestConverter(0x0?)10:08
        	/go/src/github.com/tigera/operator/pkg/controller/migration/convert/convert_suite_test.go:32 +0x17e10:08
        testing.tRunner(0xc000107860, 0x1a71bd0)10:08
        	/usr/local/go/src/testing/testing.go:1595 +0xff10:08
        created by testing.(*T).Run in goroutine 110:08
        	/usr/local/go/src/testing/testing.go:1648 +0x3ad10:08
------------------------------10:08
Convert network tests handle Calico CNI migration Calico CNI config flags migrate tuning setting 10:08
  not allowed sysctl tuning in config10:08
  /go/src/github.com/tigera/operator/pkg/controller/migration/convert/network_test.go:814