Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.34] License Usage Collection #3362

Merged
merged 1 commit into from
May 28, 2024
Merged

[v1.34] License Usage Collection #3362

merged 1 commit into from
May 28, 2024

Conversation

pasanw
Copy link
Contributor

@pasanw pasanw commented May 24, 2024

Description

picks #3346

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.34.0 milestone May 24, 2024
@pasanw pasanw marked this pull request as ready for review May 28, 2024 00:08
@pasanw pasanw requested a review from a team as a code owner May 28, 2024 00:08
@pasanw pasanw merged commit 2872eae into tigera:release-v1.34 May 28, 2024
2 checks passed
@pasanw pasanw deleted the license-usage-collection-v1.34 branch May 28, 2024 20:06
@danudey danudey modified the milestones: v1.34.0, v1.34.1 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.34.1
Development

Successfully merging this pull request may close these issues.
4 participants
@pasanw @caseydavenport @danudey @marvin-tigera