[EV-5126] Rename and update tigera-crds clusterrole #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-afra
force-pushed
the
apiserver-rbac
branch
from
eedf0af
to
e9f7321
Compare
ti-afra
changed the title
rene-dekker
reviewed
Aug 14, 2024
pkg/render/apiserver.go
Outdated
| @@ -1906,3 +1914,25 @@ func (c *apiServerComponent) multiTenantManagedClusterAccessClusterRoles() []cli | |||
|
|
|||
| return objects | |||
| } | |||
|
|
|||
| func (c *apiServerComponent) getDeprecatedResources() []client.Object { | |||
| renamedRscList := []client.Object{} | |||
There was a problem hiding this comment.
nit: it could be replaced with empty slice declaration:
var renamedRscList []client.Object
rene-dekker
reviewed
Aug 14, 2024
pkg/render/apiserver.go
Outdated
| @@ -279,6 +279,9 @@ func (c *apiServerComponent) Objects() ([]client.Object, []client.Object) { | |||
| // Explicitly delete any global OSS objects. | |||
| // Namespaced objects will be handled by namespace deletion. | |||
| objsToDelete = append(objsToDelete, globalCalicoObjects...) | |||
|
|
|||
| // Explicitly delete any renamed/deprecated objects. | |||
| objsToDelete = append(objsToDelete, c.getDeprecatedResources()...) | |||
There was a problem hiding this comment.
I think this can be outside (under) the if-else statement. This always needs to get deleted, regardless of whether the cluster is enterprise right now.
There was a problem hiding this comment.
I moved it outside, but for opensource we dont have the "tigera-crds" clusterrole and the apiserver binding. Doesn't it matter or wouldn't it fail if they dont exist?
rene-dekker
reviewed
Aug 14, 2024
| @@ -1258,26 +1261,31 @@ func (c *apiServerComponent) tigeraCustomResourcesClusterRole() *rbacv1.ClusterR | |||
| "patch", | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Please if you could add a comment as to why we need this permission, it will help us track over time why we added permissions and also make it easier to remove unused permissions.
ti-afra
force-pushed
the
apiserver-rbac
branch
2 times, most recently
from
7437633
to
7b9e125
Compare
…o it Changes: 1. Rename "tigera-crds" clusterrole to "tigera-apiserver" 2. Add "authorizationreviews" rbac to "tigera-apiserver" clusterrole; queryserver needs this rbac to return authorized list of items in the resultset. 3. Rename "tigera-apiserver-access-tigera-crds" clusterrolebinding to "tiger-apiserver"
ti-afra
force-pushed
the
apiserver-rbac
branch
from
7b9e125
to
5724208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.