Switch to new machine type in semaphore CI #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brian-McM
reviewed
Aug 15, 2024
.semaphore/push_images.yml
Outdated
| @@ -2,7 +2,7 @@ version: v1.0 | |||
| name: Operator CD | |||
| agent: | |||
| machine: | |||
| type: e1-standard-4 | |||
| type: f1-standard-4 | |||
There was a problem hiding this comment.
I think this can actually be f1-standard-2, I think these machines are bigger. The 4 is apparently much larger, might want to check with @sujeet-kr though.
There was a problem hiding this comment.
Yes e1-standard-4's can be replaced with f1-standard-2s, if the reason for using e1-standard-4 was memory and storage.
Suggested change
| type: f1-standard-4 | |
| type: f1-standard-2 |
sujeet-kr
reviewed
Aug 15, 2024
.semaphore/semaphore.yml
Outdated
| @@ -137,7 +137,7 @@ blocks: | |||
| task: | |||
| agent: | |||
| machine: | |||
| type: e1-standard-4 | |||
| type: f1-standard-4 | |||
There was a problem hiding this comment.
Suggested change
| type: f1-standard-4 | |
| type: f1-standard-2 |
tmjd
force-pushed
the
sem-machine-change
branch
from
9fa47b5
to
f1c89ca
Compare
Brian-McM
approved these changes
Aug 15, 2024
5 tasks
tmjd
added
release-note-not-required
docs-not-required
and removed
docs-pr-required
release-note-required
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.