Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP pool config to disable new allocations #3472

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

caseydavenport
Copy link
Member

Description

Add new operator API field to IP pools that is equivalent to the exisitng IP pool spec.disabled option.

This is necessary if we want to implement IP pool migration logic from this guide using the operator API: https://docs.tigera.io/calico/3.27/networking/ipam/migrate-pools#tutorial

Separately, I do wonder if we could make pool migraiton even easier in operator mode - could the operator automatically do most of those steps?

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

pkg/controller/ippool/defaults.go Outdated Show resolved Hide resolved
@caseydavenport caseydavenport merged commit 6eeefb1 into tigera:master Aug 27, 2024
5 checks passed
@caseydavenport caseydavenport deleted the casey-disable-new-alloc branch August 27, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants