Restrict tigera-operator secret access to namespace only #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara2504
force-pushed
the
operator_rbac
branch
2 times, most recently
from
3feb8e6 to
046006e
Compare
vara2504
changed the title
vara2504
force-pushed
the
operator_rbac
branch
3 times, most recently
from
c5e209c to
34f0c59
Compare
Merged
3 tasks
rene-dekker
reviewed
Dec 13, 2024
| @@ -186,6 +186,8 @@ func (mc *monitorComponent) Objects() ([]client.Object, []client.Object) { | |||
| render.CreateNamespace(common.TigeraPrometheusNamespace, mc.cfg.Installation.KubernetesProvider, render.PSSBaseline, mc.cfg.Installation.Azure), | |||
| } | |||
|
|
|||
| toCreate = append(toCreate, render.CreateOperatorSecretsRoleBinding(common.TigeraPrometheusNamespace)) | |||
There was a problem hiding this comment.
On line 239 we may be creating a secret for which the operator requires permissions. Should we render a binding in that namespace prior to rendering the secret?
rene-dekker
requested changes
Dec 13, 2024
…watch/list cluster-wide
vara2504
force-pushed
the
operator_rbac
branch
from
34f0c59 to
5fd7a16
Compare
5 tasks
vara2504
force-pushed
the
operator_rbac
branch
from
5fd7a16 to
ad4b1b3
Compare
rene-dekker
approved these changes
Dec 17, 2024
|
/merge-when-ready |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
rene-dekker
pushed a commit
that referenced
this pull request
Dec 18, 2024
… only (#3653) * Restrict tigera-operator secret access to namespace only, retain get/watch/list cluster-wide * Add secrets rolebinding for external prometheus * Trigger Build
nelljerram
added a commit
to nelljerram/operator
that referenced
this pull request
Dec 19, 2024
(Per pattern of tigera#3630) Also fix a log typo
nelljerram
added a commit
to nelljerram/operator
that referenced
this pull request
Dec 19, 2024
(Per pattern of tigera#3630) Also fix a log typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict tigera-operator secret access to namespace only, retain get/list/watch cluster-wide
https://tigera.atlassian.net/browse/EV-5410
Tested external prometheus ,
bz addons run external-prometheus:setup
bz addons run wireguard:setup
External-prometheus E2E passed
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.