Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch releasing based on tag #3661

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

radTuti
Copy link
Contributor

@radTuti radTuti commented Dec 19, 2024

Description

This creates a separate semaphore file to use for releasing Operator based off tagging

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@radTuti radTuti requested a review from a team December 19, 2024 00:38
@radTuti radTuti requested a review from a team as a code owner December 19, 2024 00:38
@marvin-tigera marvin-tigera added this to the v1.38.0 milestone Dec 19, 2024
@radTuti radTuti force-pushed the release-tag branch 4 times, most recently from ca8efd8 to 59284a0 Compare December 19, 2024 00:48
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we're changing how we're cleaning the cache to make the building of a tag quicker with the result of slowing down any re-runs of a failed run. I would guess re-runs are going to happen much more often than tag builds. So that seems like a bad trade off.

Also does this mean if someone tagged before the Build ran that this would fail?

Seems like a tag should trigger the main operator Semaphore pipeline which should then have a promotion of the 'release.yaml' pipeline if it is on a tag.

Makefile Outdated Show resolved Hide resolved
hack/maybe-build-release.sh Show resolved Hide resolved
@radTuti radTuti requested a review from tmjd December 19, 2024 19:20
.semaphore/semaphore.yml Outdated Show resolved Hide resolved
@radTuti radTuti requested a review from tmjd December 19, 2024 21:54
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment that you can ignore if you don't think it would help.

Makefile Outdated Show resolved Hide resolved
@radTuti
Copy link
Contributor Author

radTuti commented Dec 20, 2024

/merge-when-ready squash-commits delete-branch

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, squash the commits when I merge it, and delete the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit d12f316 into tigera:master Dec 20, 2024
5 checks passed
@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

@radTuti radTuti deleted the release-tag branch December 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants