-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch releasing based on tag #3661
Conversation
ca8efd8
to
59284a0
Compare
for when cache is not available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we're changing how we're cleaning the cache to make the building of a tag quicker with the result of slowing down any re-runs of a failed run. I would guess re-runs are going to happen much more often than tag builds. So that seems like a bad trade off.
Also does this mean if someone tagged before the Build ran that this would fail?
Seems like a tag should trigger the main operator Semaphore pipeline which should then have a promotion of the 'release.yaml' pipeline if it is on a tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment that you can ignore if you don't think it would help.
/merge-when-ready squash-commits delete-branch |
OK, I will merge the pull request when it's ready, squash the commits when I merge it, and delete the branch after I've merged it. |
I'm sorry but I failed delete the branch after merging the pull request. |
Description
This creates a separate semaphore file to use for releasing Operator based off tagging
For PR author
make gen-files
make gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.