feat: fix slice bound out of range due to incorrect usage of slice.Grow

tigerwill90 · Jul 15, 2024 · 8967adb · 8967adb
1 parent b92f025
commit 8967adb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/context.go b/context.go
@@ -315,7 +315,7 @@ func (c *cTx) CloneWith(w ResponseWriter, r *http.Request) ContextCloser {
 	cp.cachedQuery = nil
 	if cap(*c.params) > cap(*cp.params) {
 		// Grow cp.params to a least cap(c.params)
-		*cp.params = slices.Grow(*cp.params, cap(*c.params)-cap(*cp.params))
+		*cp.params = slices.Grow(*cp.params, cap(*c.params))
 	}
 	// cap(cp.params) >= cap(c.params)
 	// now constraint into len(c.params) & cap(c.params)

diff --git a/tree.go b/tree.go
@@ -651,7 +651,7 @@ Walk:
 				if !lazy {
 					if cap(*c.params) > cap(*c.tsrParams) {
 						// Grow c.tsrParams to a least cap(c.params)
-						*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params)-cap(*c.tsrParams))
+						*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params))
 					}
 					// cap(c.tsrParams) >= cap(c.params)
 					// now constraint into len(c.params) & cap(c.params)
@@ -693,7 +693,7 @@ Walk:
 						if !lazy {
 							if cap(*c.params) > cap(*c.tsrParams) {
 								// Grow c.tsrParams to a least cap(c.params)
-								*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params)-cap(*c.tsrParams))
+								*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params))
 							}
 							// cap(c.tsrParams) >= cap(c.params)
 							// now constraint into len(c.params) & cap(c.params)
@@ -711,7 +711,7 @@ Walk:
 						if !lazy {
 							if cap(*c.params) > cap(*c.tsrParams) {
 								// Grow c.tsrParams to a least cap(c.params)
-								*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params)-cap(*c.tsrParams))
+								*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params))
 							}
 							// cap(c.tsrParams) >= cap(c.params)
 							// now constraint into len(c.params) & cap(c.params)
@@ -752,7 +752,7 @@ Walk:
 				if !lazy {
 					if cap(*c.params) > cap(*c.tsrParams) {
 						// Grow c.tsrParams to a least cap(c.params)
-						*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params)-cap(*c.tsrParams))
+						*c.tsrParams = slices.Grow(*c.tsrParams, cap(*c.params))
 					}
 					// cap(c.tsrParams) >= cap(c.params)
 					// now constraint into len(c.params) & cap(c.params)