feat: support context params wrapping #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
8a2b216 to
6f1b55f
Compare
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 86.27% 86.41% +0.13%
==========================================
Files 12 12
Lines 1771 1789 +18
==========================================
+ Hits 1528 1546 +18
Misses 210 210
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
obito
reviewed
Jun 12, 2023
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
6f1b55f to
3e512e1
Compare
pawndev
reviewed
Jun 12, 2023
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
3e512e1 to
1b11329
Compare
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
1b11329 to
d4f8af1
Compare
hbenhoud
changed the title
tigerwill90
reviewed
Jun 13, 2023
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
d4f8af1 to
f3458a3
Compare
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
f3458a3 to
9a1383d
Compare
hbenhoud
force-pushed
the
feat/params-from-context
branch
from
9a1383d to
e8d70f6
Compare
tigerwill90
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
goos: linux
goarch: amd64
pkg: github.com/tigerwill90/fox
cpu: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
StaticAll-16 11.23µ ± 0% 11.27µ ± 1% ~ (p=0.684 n=10)
GithubParamsAll-16 85.67n ± 1% 87.35n ± 3% +1.96% (p=0.023 n=10)
OverlappingRoute-16 98.93n ± 0% 98.92n ± 1% ~ (p=0.698 n=10)
StaticParallel-16 9.052n ± 12% 8.916n ± 1% -1.50% (p=0.005 n=10)
CatchAll-16 33.76n ± 4% 32.23n ± 2% -4.55% (p=0.001 n=10)
CatchAllParallel-16 5.192n ± 21% 4.439n ± 13% -14.49% (p=0.023 n=10)
MultiWriter-16 106.1n ± 1% 106.6n ± 1% ~ (p=0.362 n=10)
PathClean-16 805.6n ± 1% 762.7n ± 1% -5.32% (p=0.000 n=10)
PathCleanLong-16 4.535m ± 25% 4.328m ± 25% ~ (p=0.529 n=10)
geomean 338.6n 327.8n -3.20%
No regression in benchmark, lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.