Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Duster glob support using Symfony finder #136

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

driftingly
Copy link
Member

This PR updates the Duster's wildcard support for include/exclude configurations.

Previously a configuration using a wildcard glob would not work:

{
    "exclude": [
        "tests/**/Fixture"
    ]
}

This PR runs these patterns through Symfony's finder and falls back to the previous glob method.

@driftingly driftingly force-pushed the drift/improve-duster-glob-support branch from a0074cb to 19c80f9 Compare December 15, 2023 20:08
@driftingly driftingly merged commit a184db3 into 2.x Dec 15, 2023
6 checks passed
@driftingly driftingly deleted the drift/improve-duster-glob-support branch December 15, 2023 20:18
@mattstauffer
Copy link
Member

@driftingly This bumps us from Tlint 8 to Tlint 9, which changes PHP requirement from 8.0 to 8.1, so this'll need to be a minor or even possibly major release, can't remember which we're allowed to increase dependencies in.

@driftingly
Copy link
Member Author

@mattstauffer Duster already requires PHP 8.1 since Pint 1.6+ requires 8.1 and was the reason we went from 1.x to 2.x.
I did release this as a minor because there were a lot of other dependency updates.

@benholmen
Copy link
Contributor

FYI this PR caused a regression for me. My duster.json file was:

{
    "include": [],
    "exclude": ["bootstrap/*", "app/Http/Controllers/Auth/*"]
}

but after upgrading v2.6.0 => v2.7.1, I started getting lint errors on bootstrap.php and an Auth controller.

I updated my config to the following and it worked:

{
    "include": [],
    "exclude": ["bootstrap", "app/Http/Controllers/Auth"]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants