feat: added minimal pubsub implementation #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 91.93% 91.81% -0.13%
==========================================
Files 7 8 +1
Lines 1687 1808 +121
Branches 252 268 +16
==========================================
+ Hits 1551 1660 +109
- Misses 135 147 +12
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
himank
reviewed
Aug 8, 2022
himank
reviewed
Aug 8, 2022
himank
reviewed
Aug 8, 2022
JigarJoshi
reviewed
Aug 8, 2022
JigarJoshi
reviewed
Aug 8, 2022
src/topic.ts
Outdated
| onError(error: Error): void; | ||
| } | ||
|
|
||
| export class Topic<T extends TigrisCollectionType> { |
There was a problem hiding this comment.
please add test to cover this.
mattayres
force-pushed
the
pubsub_init
branch
2 times, most recently
from
ec90fff to
e68b4a4
Compare
JigarJoshi
reviewed
Aug 22, 2022
| done(); | ||
| }, | ||
| onEnd() { | ||
| // not expected to be called |
There was a problem hiding this comment.
nit: should we put fail() here to get tighter grip?
There was a problem hiding this comment.
I've tried to add this before, it hits this bug: jestjs/jest#11698
JigarJoshi
approved these changes
Aug 22, 2022
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.