Apply changes introduced by ghaf PR724 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should be merged only after tiiuae/ghaf#724 has been merged in. |
In ghaf PR724 element-vm is changed to comms-vm and also Slack App is added to the VM. With these fixes the element launch test survives the changes. Added also launch test for the Slack App. In addition created separate lenovo-x1 specific performance threshold parameter for fileio read test because lenovo-x1 fileio rd test results jumped very high few weeks ago causing also variance of the results to increase compared to other targets. So assigning a larger threshold for this specific test/target was appropriate. Signed-off-by: Samuli Leivo <samuli.leivo@unikie.com>
leivos-unikie
force-pushed
the
switch_to_comms-vm
branch
from
8bceebc
to
c5a8588
Compare
azbeleva
approved these changes
Aug 20, 2024
|
ghaf PR#724 went in yesterday evening, so now it is time to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ghaf PR724 element-vm is changed to comms-vm and also Slack App is added to the VM. With these fixes the element launch test (kill processes part) survives the changes. Added also launch test for the new Slack App.
In addition created separate lenovo-x1 specific performance threshold parameter for fileio read test because lenovo-x1 fileio rd test results jumped very high few weeks ago causing also variance of the results to increase compared to other targets. So assigning a larger threshold for this specific test/target was appropriate.