Changes to use congif file to get needed data #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get all needed data from config file about target test device. No hard coded data to Jenkinsfiles. Signed-off-by: Ville-Pekka Juntunen <ville-pekka.juntunen@unikie.com>
azbeleva
approved these changes
Aug 31, 2023
| @@ -2,4 +2,4 @@ pyserial==3.5 | |||
| robotframework-seriallibrary==0.4.2 | |||
| robotframework-sshlibrary==3.8.0 | |||
| robotframework==5.0.1 | |||
| PyP100==0.0.19 | |||
There was a problem hiding this comment.
on Production side devices work with old version on this lib, so maybe we shouldn't change it in requirements right now
|
|
||
| // Check for which agent and which target device | ||
| if ("${params.label}" == "tc-agent02"){ | ||
| if (params.device == "Orin"){ |
There was a problem hiding this comment.
Maybe we should stop using name 'Orin' because now we have two deffirenet Orins: AGX and NX. Let's take it into account now already
There was a problem hiding this comment.
decided to make it in different branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get all needed data from config file about target test device. No hard coded data to Jenkinsfiles.