Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioVM and client configuration with separate VM audio chennels #722

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josa41
Copy link
Contributor

@josa41 josa41 commented Aug 9, 2024

Description of changes

AudioVM configuration which adds Audio IO channels for VMs (per confiugration).
Clean up of AppVM configuration to add client audioVM connections based on VM name

Checklist for things done

  • [X ] Summary of the proposed changes in the PR description
  • [X ] More detailed description in the commit message(s)
  • [X ] Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • [X ] Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • [X ] Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@josa41 josa41 temporarily deployed to internal-build-workflow August 9, 2024 13:38 — with GitHub Actions Inactive
@josa41 josa41 marked this pull request as draft August 9, 2024 13:38
@josa41 josa41 requested review from baz2142 and mbssrc August 9, 2024 13:39
@@ -77,6 +132,51 @@ in {
script = ''${pkgs.pulseaudio}/bin/pa-info > /dev/null 2>&1'';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use lingering (see below) instead of the pulseaudio-starter service?

systemd.tmpfiles.rules = [
  "f /var/lib/systemd/linger/${config.ghaf.users.accounts.user}"
];

@@ -77,6 +132,51 @@ in {
script = ''${pkgs.pulseaudio}/bin/pa-info > /dev/null 2>&1'';
};

# TODO Automate and fix alsa IO ports
systemd.services."pipewire-link-starter" = let
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that we want to aim at dynamic support, i.e., supporting several input/output devices such as bluez_input/output, starting with auto-switch and later selection.

Signed-off-by: Jon Sahlberg <jon.sahlberg@unikie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants