Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluation: cosmic #777

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

evaluation: cosmic #777

wants to merge 1 commit into from

Conversation

vilvo
Copy link
Contributor

@vilvo vilvo commented Sep 6, 2024

Description of changes

  • boots to greeter login and logins to cosmic
  • tested with - note reduction of default jobs to 4 if you face rust build break:
nixos-rebuild -j 4 --flake .#lenovo-x1-carbon-gen11-debug --target-host root@<ip> switch
  • based on Ivan's work in ghaf-based downstream project

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@unbel13ver @vilvo
evaluation: cosmic
8ce4378 
* boots to greeter login and logins to cosmic
* tested with - note reduction of default jobs to 4 if you face rust build break
nixos-rebuild -j 4 --flake .#lenovo-x1-carbon-gen11-debug --target-host root@<ip> switch
* based on Ivan's work in ghaf-based downstream project

Co-authored-by: Ville Ilvonen <ville.ilvonen@unikie.com>
Signed-off-by: Ville Ilvonen <ville.ilvonen@unikie.com>
@vilvo vilvo temporarily deployed to internal-build-workflow September 6, 2024 09:57 — with GitHub Actions Inactive
@vilvo vilvo marked this pull request as draft September 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unbel13ver unbel13ver Awaiting requested review from unbel13ver

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vilvo @unbel13ver