bench: add bench action #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 89.64% 89.47% -0.18%
==========================================
Files 39 39
Lines 8739 8739
==========================================
- Hits 7834 7819 -15
- Misses 905 920 +15 |
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
GanZiheng
force-pushed
the
add-bench-action
branch
from
a3e7611 to
ff11cd0
Compare
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Connor1996
reviewed
Jul 5, 2022
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Connor1996
reviewed
Jul 6, 2022
Connor1996
reviewed
Jul 6, 2022
benches/benches_badger_rocks.rs
Outdated
| opts.dir = dir_path.to_path_buf(); | ||
| opts.value_dir = dir_path.to_path_buf(); | ||
|
|
||
| c.bench_function("badger populate large value", |b| { |
There was a problem hiding this comment.
should reuse the bench_badger impl with value size as a variable.
There was a problem hiding this comment.
In fact, I found we could not simply reuse them.
|
This is screenshot of GitHub page about benchmark result. |
can we merge the same case for badger and rocks in one diagram? |
|
Seems we cannot do it 🤣 |
After modifying the html file generated by the action, we could get something like this. |
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Connor1996
reviewed
Jul 7, 2022
Connor1996
reviewed
Jul 7, 2022
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GanZiheng ganziheng98@gmail.com