Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc fix : default value of checksum_mode #175

Merged
merged 2 commits into from
Jul 10, 2022
Merged

doc fix : default value of checksum_mode #175

merged 2 commits into from
Jul 10, 2022

Conversation

gcxfd
Copy link
Contributor

@gcxfd gcxfd commented Jul 5, 2022

No description provided.

GanZiheng
GanZiheng approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@GanZiheng GanZiheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this.

@GanZiheng
Copy link
Contributor

Please signed off your commits by git commit -s for example.

Connor1996
Connor1996 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcxfd
doc fix : default value of checksum_mode
fc1b08a 
Signed-off-by: gcxfd <i@rmw.link>
@gcxfd
Copy link
Contributor Author

gcxfd commented Jul 6, 2022

Please signed off your commits by git commit -s for example.

added

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #175 (f04b6f9) into master (5c7235e) will increase coverage by 0.89%.
The diff coverage is 90.06%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   88.63%   89.52%   +0.89%     
==========================================
  Files          38       39       +1     
  Lines        8596     8739     +143     
==========================================
+ Hits         7619     7824     +205     
+ Misses        977      915      -62

@zhangjinpeng87 zhangjinpeng87 merged commit e987131 into tikv:master Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GanZiheng GanZiheng GanZiheng approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gcxfd @GanZiheng @Connor1996 @zhangjinpeng87