Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt: has option switch key value separation off #182

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

zhangjinpeng87
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 commented Jul 12, 2022

Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #182 (12ca31e) into master (a4e06f1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   89.54%   89.60%   +0.06%     
==========================================
  Files          39       39              
  Lines        8739     8752      +13     
==========================================
+ Hits         7825     7842      +17     
+ Misses        914      910       -4     

@zhangjinpeng87 zhangjinpeng87 merged commit 475e17b into tikv:master Jul 13, 2022
@zhangjinpeng87 zhangjinpeng87 deleted the vlog-off branch July 13, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants