Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An unready store might be marked as reachable #1111

Closed
zyguan opened this issue Jan 12, 2024 · 0 comments · Fixed by #1127
Closed

An unready store might be marked as reachable #1111

zyguan opened this issue Jan 12, 2024 · 0 comments · Fixed by #1127

Comments

@zyguan
Copy link
Contributor

zyguan commented Jan 12, 2024

The health check loop will do reResolve periodically. If the store meta changed, a new store will be inserted and the old one will be marked as deleted. Both old store and new store are marked as reachable at the end of the health check loop. As a result, tidb may access this unready store and requests finally timeout.
@zyguan zyguan mentioned this issue Jan 22, 2024
Merged
@zyguan zyguan mentioned this issue Jan 26, 2024
Open
zyguan added a commit to zyguan/client-go that referenced this issue Apr 28, 2024
@zyguan
cherry pick tikv#1127 to fix tikv#1111
3a59596 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan zyguan mentioned this issue Apr 28, 2024
Merged
disksing pushed a commit that referenced this issue Apr 28, 2024
@zyguan
cherry pick #1127 to fix #1111 (#1324)
2de9b7d 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
iosmanthus added a commit that referenced this issue Jul 9, 2024
@iosmanthus
merge upstream tidb-7.5 (#1370)
b4e4756 
Co-authored-by: zzm <zhouzemin@pingcap.com>
Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: disksing <i@disksing.com>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
Co-authored-by: zyguan <zhongyangguan@gmail.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: crazycs <crazycs520@gmail.com>
fix: check kill signal against 0 (#1102)" (#1129)"
fix #1111 (#1324)
fix rpc client panic cause by concurrent close (#1358)
@zyguan zyguan mentioned this issue Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the issue that health check may set liveness wrongly zyguan/client-go
1 participant
@zyguan