Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region cache: retry scan or batch scan regions when returned region has no leader #1480

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

cfzjywxk
Copy link
Contributor

Ref: pingcap/tidb#56757

When there is no leader information for all the returned regions, retry scan or batch scan region from PD but not return errors to the upper layer.

Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@cfzjywxk cfzjywxk added the type/bugfix This PR fixes a bug. label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2024
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 13:04:01.338091908 +0000 UTC m=+356242.034882516: ☑️ agreed by crazycs520.
  • 2024-10-23 02:26:53.925594699 +0000 UTC m=+404414.622385323: ☑️ agreed by you06.

@ti-chi-bot ti-chi-bot bot merged commit 691e80a into tikv:master Oct 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants