Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a columnFamily feature for client-go when use rawput in tikv #425

Merged
merged 9 commits into from
Mar 2, 2022
Merged

Add a columnFamily feature for client-go when use rawput in tikv #425

merged 9 commits into from
Mar 2, 2022

Conversation

joccau
Copy link
Contributor

@joccau joccau commented Feb 20, 2022

The function of pr: As title
close #424

@joccau
Add columnFamily parameter for client-go
eb8617f 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
maintain and add testcase for cf params, ref tikv#424
48fcc51 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Copy link
Contributor Author

joccau commented Feb 20, 2022

/cc @disksing @AndreMouche @kennytm @sticnarf PTAL

kennytm
kennytm approved these changes Feb 21, 2022
View reviewed changes
internal/mockstore/mocktikv/mvcc_leveldb.go Outdated Show resolved Hide resolved
@joccau
Deal comments in pr
fa5b4de 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Merge remote-tracking branch 'origin/master' into add-cf-params
a14e10a 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@disksing
Copy link
Collaborator

Hi @joccau there some lint warnings. We need them be fixed before merging this PR. Thanks!

joccau added 5 commits March 1, 2022 11:28
@joccau
Deal the lint static-check
1f580ad 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
run lint static-check
31101db 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Add rawkvOption parameters for rawkv API
357ed14 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
remove scanOption
6875549 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Add test cases
0e76ce2 
Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Copy link
Contributor Author

joccau commented Mar 1, 2022

/cc @disksing @kennytm PTAL again~

@joccau
Copy link
Contributor Author

joccau commented Mar 1, 2022

/cc @hicqu PTAL

@disksing
Copy link
Collaborator

disksing commented Mar 2, 2022

Thanks @joccau

@disksing disksing merged commit d3c2456 into tikv:master Mar 2, 2022
@disksing disksing mentioned this pull request Mar 2, 2022
Closed
@joccau joccau mentioned this pull request Mar 2, 2022
Merged
This was referenced Mar 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing left review comments

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a columnFamily feature for client-go when use rawput in tikv
3 participants
@joccau @disksing @kennytm