Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: make txn_source be u64 type #618

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Nov 17, 2022

we use u64 to reserve more space for future use. For now, the upper application is limited to setting this value under 0x80, so there will no more cost to change it to u64

Signed-off-by: xiongjiwei xiongjiwei1996@outlook.com

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei xiongjiwei closed this Nov 17, 2022
@xiongjiwei xiongjiwei reopened this Nov 17, 2022
@sticnarf
Copy link
Collaborator

Maybe change the TiKV lock encoding part first?

Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
Copy link
Contributor Author

Maybe change the TiKV lock encoding part first?

yes, I will do

@xiongjiwei
Copy link
Contributor Author

/cc @sticnarf @MyonKeminta

Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge after merging the corresponding PR in TiKV.

@xiongjiwei
Copy link
Contributor Author

/cc @sticnarf please help merge

@sticnarf sticnarf merged commit e9db9e6 into tikv:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants