export region and peer for batch cop #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
sticnarf
reviewed
Dec 1, 2022
| StartKey []byte | ||
| EndKey []byte | ||
| Buckets *metapb.Buckets | ||
| RawRegion *Region |
There was a problem hiding this comment.
Now this struct looks very strange. The other fields can be get from RawRegion...
There was a problem hiding this comment.
That's right, but I don't want to break the compatibility...
There was a problem hiding this comment.
Then, it adds something strange that cannot be deleted forever in the future for compatibility...
Now, I think we can just use GetTiKVRPCContext for the information we want. We can polish the way in the future.
There was a problem hiding this comment.
GetTiKVRPCContext +1, though the clock is ticking, better to keep it easy to maintain
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: you06 you1474600@gmail.com
ref pingcap/tidb#39361
This PR export the region and peer structs for batch cop usage.