Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't call onMemChange before all work is done in memdb #636

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Dec 7, 2022

ref pingcap/tidb#39611

This is a workaround.
The real problem is that we broke the assumption that some functions should not panic. This is related to how the memory tracking system works, which should be discussed later.

Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
Copy link
Contributor Author

ekexium commented Dec 7, 2022

Even if we fix this, I doubt transactions or anything stateful in TiDB could be affected by unexpected panic, and bugs occur.

@sticnarf @disksing What do you think?

@disksing
Copy link
Collaborator

disksing commented Dec 8, 2022

It is reasonable. Merging.

@disksing disksing merged commit 6d5cb2d into tikv:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants