Introduce the RURuntimeStats #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
5dc1b0a to
24b675b
Compare
3 tasks
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
bd50ebb to
ed68b15
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
ed68b15 to
21aa2e2
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
glorv
reviewed
Mar 14, 2023
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
a189b02 to
24cc6df
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
24cc6df to
249992d
Compare
Connor1996
reviewed
Mar 14, 2023
txnkv/txnsnapshot/snapshot.go
Outdated
| @@ -391,6 +391,7 @@ func (s *KVSnapshot) batchGetSingleRegion(bo *retry.Backoffer, batch batchKeys, | |||
| Keys: pending, | |||
| Version: s.version, | |||
| }, s.mu.replicaRead, &s.replicaReadSeed, kvrpcpb.Context{ | |||
| StartTs: s.version, | |||
There was a problem hiding this comment.
All the places that you set StartTs are just a copy of start version in each type of command. How about getting the start ts with a match of the request type instead of adding a new field in context
nolouch
reviewed
Mar 14, 2023
| } | ||
|
|
||
| func (r interceptedClient) SendRequest(ctx context.Context, addr string, req *tikvrpc.Request, timeout time.Duration) (*tikvrpc.Response, error) { | ||
| // Build the resource control interceptor. | ||
| resourceGroupName := req.GetResourceGroupName() | ||
| var finalInterceptor interceptor.RPCInterceptor = buildResourceControlInterceptor(ctx, req, resourceGroupName) | ||
| var finalInterceptor interceptor.RPCInterceptor = buildResourceControlInterceptor(ctx, req, r.getRURuntimeStats(req.GetStartTs())) |
There was a problem hiding this comment.
I wonder point get use same ts, if run point get workload and run a explain analazy may get wrong result?
There was a problem hiding this comment.
I checked the TiDB code and found that the point get inside an EXPLAIN ANALYZE would not use max uint64 due to the following code:
It will not be regarded as a pure point get since it's an EXPLAIN SQL after all. So its start_ts will remain unique.
tiancaiamao
reviewed
Mar 14, 2023
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
ca9bc61 to
c948aa9
Compare
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
ru_runtime_stats
branch
from
c948aa9 to
d793ffa
Compare
JmPotato
requested review from
tiancaiamao and
glorv
and removed request for
tiancaiamao
|
/cc @tiancaiamao @glorv @nolouch @Connor1996 PTAL again, thx! |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
requested review from
tiancaiamao and
Connor1996
and removed request for
glorv and
tiancaiamao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref pingcap/tidb#41972. Should merge after
pingcap/kvproto#1073 andtikv/pd#6125.Before
EXPLAIN ANALYZEis executed, it will setRURuntimeStatswith itsstart_ts, then theOnRequestandOnResponsecould get the correspondingRURuntimeStatsand update its RU info.