fix api v2 decode of region bucket's keys #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Comment on lines
+963
to
+965
| if bytes.Compare(key, c.endKey) >= 0 || bytes.Compare(key, c.prefix) < 0 { | ||
| return []byte{}, nil | ||
| } |
There was a problem hiding this comment.
should we return the corresponding prefix or endkey of the codec instead of return empty slice?
what happen when nil slice is return as bucket boundary, would pd interpret them as region boundary?
There was a problem hiding this comment.
This function aims for decoding the key, for example, if there is a region ranged in [x0001, x0003), and the keyspace 002 tries to decode the bucket key "x0001test", then the key for keyspace 002 doesn't exist, we might decode them as "".
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request decodes the region bucket key by mapping them into the keyspace range.
If the bucket key is in the keyspace, then decode it as usual, otherwise map it as
nil.